tests: Reset umask to 022 while creating test repository
authorSimon McVittie <smcv@collabora.com>
Tue, 19 Sep 2017 17:37:58 +0000 (18:37 +0100)
committerAtomic Bot <atomic-devel@projectatomic.io>
Tue, 19 Sep 2017 20:41:36 +0000 (20:41 +0000)
commite3c3ec5dd91492e82c79223052443d038c60f41c
tree8bb09823bf3165d7a903230471c4db67fc89436a
parentdb10bf464fcf28e3c21724353ffd6168c9f77aae
tests: Reset umask to 022 while creating test repository

In test-basic-root.sh we make assertions about the permissions
of files like baz/cow, which were created without an explicit chmod.
We can't do that unless we control the permissions.

For some reason the "debomatic" autobuilder used to do some Debian
archive rebuilds does the entire build including build-time tests
as uid 0 with umask 002, which broke those assertions. This seems
a weird thing to do, and I've opened a bug, but it also seems
reasonable to fix this test.

This also lets us remove a couple of existing workarounds for the
same issue.

Bug-Debian: https://bugs.debian.org/876138
Signed-off-by: Simon McVittie <smcv@collabora.com>
Closes: #1192
Approved by: cgwalters
tests/libtest.sh
tests/test-basic-user.sh